Skip to content

fix(core): store assets as raw bytes instead of File objects in Index… - #912

Open
DoudouDoudouk wants to merge 3 commits into
pascalorg:mainfrom
DoudouDoudouk:fix/asset-storage-webkit
Open

DoudouDoudouk wants to merge 3 commits into
pascalorg:mainfrom
DoudouDoudouk:fix/asset-storage-webkit

Conversation

@DoudouDoudouk

@DoudouDoudouk DoudouDoudouk commented Sep 23, 2026 •

Copy link
Copy Markdown

…edDB

saveAsset put the File itself into IndexedDB. Not every engine accepts File/Blob records (WebKit rejects the write), so every upload that goes through saveAsset failed there with no fallback.

Store { assetVersion: 1, bytes, type } instead, which uses the portable structured-clone path. loadAssetUrl rebuilds a Blob from that record, still reads File/Blob records written before this change, and returns null for an unreadable record instead of throwing inside createObjectURL.

What does this PR do?

How to test

Screenshots / screen recording

Checklist

  • I've tested this locally with bun dev
  • My code follows the existing code style (run bun check to verify)
  • I've updated relevant documentation (if applicable)
  • This PR targets the main branch

Note

Medium Risk
Touches client-side asset upload/load used across the editor; behavior change is backward compatible but affects all paths that call saveAsset/loadAssetUrl.

Overview
IndexedDB asset persistence now writes a versioned { bytes, type } record instead of storing the File directly, fixing failures on engines (e.g. WebKit) that reject File/Blob values in IndexedDB.

loadAssetUrl rebuilds a Blob from that record via new helpers, keeps loading older File/Blob entries, and returns null with a warning when the stored value cannot be turned into a blob—avoiding throws from URL.createObjectURL. Tests cover the new on-disk shape, legacy records, and broken data.

Reviewed by Cursor Bugbot for commit e186799. Bugbot is set up for automated code reviews on this repo. Configure here.

…edDB

saveAsset put the File itself into IndexedDB. Not every engine accepts
File/Blob records (WebKit rejects the write), so every upload that goes
through saveAsset failed there with no fallback.

Store { assetVersion: 1, bytes, type } instead, which uses the portable
structured-clone path. loadAssetUrl rebuilds a Blob from that record,
still reads File/Blob records written before this change, and returns
null for an unreadable record instead of throwing inside createObjectURL.
@pascal

pascal Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…).

Please try again, rephrase, or reach out if it keeps failing.

Error id: 550823bd-bd72-4994-9e26-6cad61eb3629

@Aymericr Aymericr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, @DoudouDoudouk. The byte record plus the legacy Blob read path is the right approach, and the tests cover both. One small thing before merge: the old /** Save a file to IndexedDB and return a custom protocol URL */ JSDoc is now duplicated and orphaned above the StoredAssetRecord docblock. Please delete that copy and rebase onto current main. CI is also waiting on maintainer approval for this fork, and I'll merge once it's green.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants